Adds the gemset separator tests #29
Conversation
|
Hello, could you make the PR against https://github.com/rvm/rvm? As mentioned on Slack I think we should archive this repo and add a note in the README to clarify that. |
|
I added a mention in the README in 5e3fc6f @mpapis @pkuczynski OK to archive this repository to make it clear PRs should be made to rvm/rvm instead? |
mpapis
left a comment
There was a problem hiding this comment.
I do not like the idea of pre-processing the tests, bash part does evaluation of environment variables, the missing part is evaluating the test code in comments.
Best approach would be to modify tf to allow evaluation of variables in tests. Then common tests could be modified like:
rvm use 2.7.0${RVM_GEMSET_SEPARATOR} # match=/Using .*$RVM_GEMSET_SEPARATOR$/where ${RVM_GEMSET_SEPARATOR} is evaluated by shell and $RVM_GEMSET_SEPARATOR$ is evaluated by tf.
This way the tests could be made configurable and we could run same test twice. 1st with @ separator and 2nd with @@ separator.
| - recipients: | ||
| - - mpapis@gmail.com | ||
| - - me@deryldoucette.com | ||
| - on_failure: change |
|
@pkuczynski Ah, it's a git subtree: rvm/rvm#4663 (comment) I would still like to move this PR, the CI of this repository is completely outdated and merging here will not actual run the new tests when changing rvm/rvm. Given the history of these tests is probably not that valuable and the effort is synchronize is probably not worth it, I would like to still suggest to just archive this repo and let tests live in rvm/rvm, which is simpler for everybody as they are already there. |
|
Let's move the review to rvm/rvm#4832 Implementation and tests together please, otherwise it's a nightmare and we've anyway been changing rvm-test in |
The tests currently fail because the current version of rvm doesn't support @@.
you see the build here https://travis-ci.org/github/dacat/rvm-test/builds/675076020