Skip to content

Prefer to use file.stable_id over file.name from source map #148792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prefer to use file.stable_id over file.name from source map #148792

wants to merge 1 commit into from
+3 −3

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 10, 2025

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

rustc_errors::emitter was changed

cc @Muscraft

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2025
Muscraft
Muscraft approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@Muscraft Muscraft left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

View changes since this review

@Muscraft
Copy link
Member

Muscraft commented Nov 10, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 10, 2025

📌 Commit b1542c9 has been approved by Muscraft

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Muscraft Muscraft Muscraft approved these changes

Assignees

@Muscraft Muscraft

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenyukang @rustbot @Muscraft @bors