Leak mspdbsrv.exe processes on Windows #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having our job object tear them down, instead leak them intentionally if everything succeeded. Closes rust-lang#3161
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
Most of this was all taken from https://github.com/alexcrichton/rustjob which we've been using on the buildbots for quite some time now. |
Member
Author
|
This'll also likely want to be ported wholesale to rustup |
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 5ede71e has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Oct 6, 2016
Leak mspdbsrv.exe processes on Windows Instead of having our job object tear them down, instead leak them intentionally if everything succeeded. Closes #3161
Contributor
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having our job object tear them down, instead leak them intentionally
if everything succeeded.
Closes #3161