Skip to content

Added CvCircle32f constructor #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbajor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added CvCircle32f constructor #16

jbajor wants to merge 1 commit into from

Conversation

@jbajor
Copy link

@jbajor jbajor commented Jan 9, 2013

Now CvCircle32f can be created in the following way:

a = OpenCV::CvCircle32f.new(3, 4, 5)

p = OpenCV::CvPoint2D32f(20, 90)
b = OpenCV::CvCircle32f.new(p, 5)

@ser1zw
Copy link
Member

ser1zw commented Jan 14, 2013

Great! I'd like to merge you codes.
So could you modify the codes about the following points? :

  • Add some tests of this changes (see test/test_cvcircle32f.rb).
  • Use NUM2DBL() instead of NUM2INT() for setting self_ptr->radius because CvCircle32f.radius is float.

@jbajor
Copy link
Author

jbajor commented Jan 14, 2013

Sure, I will work on that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbajor @ser1zw