Issue5397 display tooltip immediately to inform error reason #6252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the reason why the rename is prohibited to avoid the user having to wait for the tooltip to be shown, default time is ~1second.
Immediately show why there is an error for the input TextBox. Help the user correct the invalid entry and not wait for the tooltip to show.
Member
|
✅ Build Rubberduck 2.5.92.6356 completed (commit 0049875ca9 by @IvenBach) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #6252 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 4 4
Lines 413 413
Branches 28 28
=======================================
Hits 403 403
Misses 6 6
Partials 4 4 |
Vogel612
approved these changes
Feb 12, 2025
retailcoder
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5397
git-blame indicates this feature was added a couple months after I opened the issue. It surprised me a bit when I let the mouse hover over the TextBox and it gave me the reason for a worksheet rename prohibition in the tooltip.
Reduced the timer to immediately show the tooltip for all TextBoxes using TextBoxErrorStyle. The faster the user can see the reason for the error the faster they
canwill correct it. TextBoxes that currently use the style reside in AnnotateDeclarationView.xaml, MoveMultipleFoldersView.xaml, MoveMultipleToFolderView.xaml, RenameView.xaml, RenameFolderView.xaml.