Add explicit image size constraint for CodeExplorer>Add menu #6251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not including a Height/Width for images in the CodeExplorer>Add menu can result in some images increasing in size from 16 to 21 pixels. Known images with this issue are: /Icons/Custom/PNG/AddModule.png /Icons/Custom/PNG/AllLoadedTests.png /Icons/Custom/PNG/BrokenReference.png /Icons/Custom/PNG/CollapseDown.png /Icons/Custom/PNG/CollapseUp.png /Icons/Custom/PNG/DisplayName.png /Icons/Custom/PNG/ExportTestRunResults.png /Icons/Custom/PNG/FolderClosedHidden.png /Icons/Custom/PNG/FolderClosedVirtual.png /Icons/Custom/PNG/FolderOpenHidden.png /Icons/Custom/PNG/FolderOpenVirtual.png /Icons/Custom/PNG/ListOfTests.png /Icons/Custom/PNG/LockedReference.png /Icons/Custom/PNG/ObjectLibraryFunction.png /Icons/Custom/PNG/ObjectPropertyGet.png /Icons/Custom/PNG/ObjectPropertyLet.png /Icons/Custom/PNG/ObjectPropertySet.png /Icons/Custom/PNG/ObjectType.png /Icons/Custom/PNG/ObjectTypeFriend.png /Icons/Custom/PNG/ObjectTypePrivate.png /Icons/Custom/PNG/ObjectTypeProtected.png /Icons/Custom/PNG/ObjectTypeSealed.png /Icons/Custom/PNG/ObjectTypeShortcut.png /Icons/Custom/PNG/Options.png /Icons/Custom/PNG/RemoveParameters.png /Icons/Custom/PNG/ReorderParameters.png /Icons/Custom/PNG/Services.png /Icons/Custom/PNG/Severity.png /Icons/Custom/PNG/StepRunTest.png /Icons/Custom/PNG/SyncArrows.png /Icons/Custom/PNG/Task.png /Icons/Custom/PNG/TestManager.png
Member
|
✅ Build Rubberduck 2.5.92.6355 completed (commit 49453b006e by @IvenBach) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #6251 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 4 4
Lines 413 413
Branches 28 28
=======================================
Hits 403 403
Misses 6 6
Partials 4 4 |
Vogel612
reviewed
Feb 11, 2025
Vogel612
approved these changes
Feb 11, 2025
retailcoder
approved these changes
Feb 19, 2025
Member
retailcoder
left a comment
There was a problem hiding this comment.
Thank you for taking the time to do this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5238
Including a Height/Width for the image will eliminate the resizing of some images in the CodeExplorer>Add menu. Within the commit message I included all images found to have this issue. I couldn't figure out the root cause though.