Implement #insert_many for batch job insertion
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46c881c to
8fbd772
Compare
Implement `#insert_many` to support inserting jobs in bulk, similar to what the Go client supports. For better ergonomics, takes either an array of job args, or an array of `InsertManyParams`, which is a tuple of job args and insert opts (again, very similar to the Go API). Also, I seem to have found a way to reimplement the ActiveRecord driver so that it doesn't have to drop down to Arel, which ends up simplifying the code quite a bit and making it more alike the Sequel driver. Lastly, tighten up documentation somewhat by including code example for the important API methods.
8fbd772 to
04213f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
#insert_manyto support inserting jobs in bulk, similar towhat the Go client supports. For better ergonomics, takes either an
array of job args, or an array of
InsertManyParams, which is a tupleof job args and insert opts (again, very similar to the Go API).
Also, I seem to have found a way to reimplement the ActiveRecord driver
so that it doesn't have to drop down to Arel, which ends up simplifying
the code quite a bit and making it more alike the Sequel driver.
Lastly, tighten up documentation somewhat by including code example for
the important API methods.