Give riverqueue.Job fully defined properties + timestamps as UTC
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8971a6d to
ff8b893
Compare
Previously, the internal sqlc `RiverJob` row was fully typed by virtue of being generated by sqlc, but the `riverqueue.Job` type was undefined, with typechecks working by using a `cast`. Here, give `riverqueue.Job` a full set of defined properties. This is better for things like conveying type information and autocomplete, but has a few other side benefits: * Make sure to return all timestamps as UTC. Previously, they'd be in whatever your local timezone is. * Give some fields like `args`, `metadata`, and `state` better types (the first two were previously `Any`). Lastly, modify `InsertResult` somewhat to make `job` non-optional since it's always returned, even if insert was skipped, because if it was we look it up via select query.
ff8b893 to
812b27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the internal sqlc
RiverJobrow was fully typed by virtueof being generated by sqlc, but the
riverqueue.Jobtype was undefined,with typechecks working by using a
cast.Here, give
riverqueue.Joba full set of defined properties. This isbetter for things like conveying type information and autocomplete, but
has a few other side benefits:
Make sure to return all timestamps as UTC. Previously, they'd be in
whatever your local timezone is.
Give some fields like
args,metadata, andstatebetter types(the first two were previously
Any).Lastly, modify
InsertResultsomewhat to makejobnon-optional sinceit's always returned, even if insert was skipped, because if it was we
look it up via select query.