Rename Args to JobArgs + modify args insert opts check + more tests
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09f18e3 to
42b6711
Compare
* Rename `Args` to `JobArgs` for better consistency with other River projects. * Use a protocol (`JobArgsWithInsertOpts`) for the check on an args for `insert_opts()` support. (Feels a little more type friendly and also how other River projects do it.) * Add tests that verify that insert opts are respected correctly and various ones that check errors that are returned on invalid insert conditions.
42b6711 to
fcf8121
Compare
brandur
added a commit
that referenced
this pull request
Jul 5, 2024
Prepare release 0.2.0, which largely just includes a rename of `Args` to `JobArgs`, a new `JobArgsWithInsertOpts` protocol for slightly nicer typing, and a few more tests [1]. [1] #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
ArgstoJobArgsfor better consistency with other Riverprojects.
Use a protocol (
JobArgsWithInsertOpts) for the check on an args forinsert_opts()support. (Feels a little more type friendly and alsohow other River projects do it.)
Add tests that verify that insert opts are respected correctly and
various ones that check errors that are returned on invalid insert
conditions.