Skip to content

Conversation

@mrazorvin
Copy link

No description provided.

@schungx
Copy link
Collaborator

schungx commented Jul 17, 2024

A couple of quick observations:

  • Try not to change existing API like register_get or else we'll break code. Better to add to the API surface instead.

  • Same for examples and tests... Try to add instead of change. This would be quite messy to undo by the time we're ready to merge.

  • Try to have as few changed files as possible as that would help with reasoning. Also it'll help putting this under a feature flag.

@schungx
Copy link
Collaborator

schungx commented Sep 30, 2024

I wonder how this is working out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants