fix failing dump command #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
@besworks Thank you for the fix 🎉 This looks good to me! I'll merge this later today and cut a new release on Pypi. |
Member
|
Although I could do the release now, I prefer doing it with fresh eyes. So I'll do it tomorrow morning as a first step after my coffee. Sorry about any inconviniences. |
gabor-boros
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
Per Issue #225
Description
The
valuesobject is an instance ofoptparse_parser.Valueswhich, as the error message states, does not support item assignment. I modified the option checker to use theensure_valuemethod of the values object to set the password.Checklist