Update net_asyncio.py #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Code Climate has analyzed commit 975e22a and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
|
Sorry about the needless notification -- I unclosed because I realized my issue or PR maintenance would step on the real maintainers' toes. And there is a legitimate wait_closed change... |
lsabi
previously approved these changes
Oct 12, 2023
lsabi
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
If applicable, link the related issue/bug report or write down in few sentences the motivation.
Description
A clear and concise description of what did you changed and why.
Code examples
If applicable, add code examples to help explain your changes.
Checklist
References
Anything else related to the change e.g. documentations, RFCs, etc.
At the python doc, a closing of async socket has that two lines:
In my case, despite closing connections, those are not closing and the number of open cons are increasing (without second line)