Fixing import command no primary key issue #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Issues
======
+ Solved 1
- Added 1
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
Restoring doesn't pick up primary_key from info files.
Description
In turned out that the primary key was parsed from the info file, but not used at table creation at all, hence the table was created with the default primary key
id. The issue was introduced right after2.3.0.post6was released in 2016.Code examples
N/A
Checklist
The whole command structure must be tested. Issue for the problem: #172
- [ ] Unit tests created/modified- [ ] Integration tests created/modifiedReferences
fixes #171
fixes #157