make DeclareStrictTypesRector skip files without namespace, as very risky in files without PSR-4 autodiscovery #7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08c41db to
bcd485b
Compare
…isky in files without PSR-4 autodsicovery
bcd485b to
95c72aa
Compare
6a2a708 to
b65e5ba
Compare
b65e5ba to
61d2789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve rule usability, as will skip front-controller files, handy scripts and legacy codebases without PSR-4.
There strict types might not be a best way to apply at first. The rest of project would benefit though 👍