Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 24, 2025

This rule adds attribute blindly, instead of helping to add missing properties instead.
What is even worse, people use it to add the attribute everywhere - https://github.com/rectorphp/rector-src/pull/1225/files
Because the rule does so. That makes code even worse, kind of counter what we're trying to do with Rector.

Instead, add known properties and aim at coherent objects. If needed, add this attribute manually to known magic objects, e.g. abstract object in some magic framework.

Reverts #1225

… PHP sets and does not help by adding attribute everywhere
@TomasVotruba TomasVotruba merged commit 3cf36b9 into main Oct 24, 2025
53 checks passed
@TomasVotruba TomasVotruba deleted the tv-depre-15 branch October 24, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants