[depre] Deprecate AddAllowDynamicPropertiesAttributeRector, as not in PHP sets and does not help by adding attribute everywhere #7568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule adds attribute blindly, instead of helping to add missing properties instead.
What is even worse, people use it to add the attribute everywhere - https://github.com/rectorphp/rector-src/pull/1225/files
Because the rule does so. That makes code even worse, kind of counter what we're trying to do with Rector.
Instead, add known properties and aim at coherent objects. If needed, add this attribute manually to known magic objects, e.g. abstract object in some magic framework.
Reverts #1225