Skip to content

[CodingStyle] Skip compare binary op on BinaryOpStandaloneAssignsToDirectRector #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2025
Merged

[CodingStyle] Skip compare binary op on BinaryOpStandaloneAssignsToDirectRector #7470

merged 2 commits into from
Oct 11, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 11, 2025

I think the following code should be skipped:

        $first = 1 + 1 + 1 + 1 +1 + 1 + 1 + 1 + 1 + 1;
        $second = 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2;

        return $first <=> $second;

since it got unreadable after applied.

-        $first = 1 + 1 + 1 + 1 +1 + 1 + 1 + 1 + 1 + 1;
-        $second = 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2;
-
-        return $first <=> $second;
+        return 1 + 1 + 1 + 1 +1 + 1 + 1 + 1 + 1 + 1 <=> 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2;

@samsonasik
Copy link
Member Author

samsonasik commented Oct 11, 2025

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Oct 11, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 11, 2025 10:31
@samsonasik samsonasik merged commit 5697100 into main Oct 11, 2025
53 checks passed
@samsonasik samsonasik deleted the skip-compare-binary-op branch October 11, 2025 10:32
@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 11, 2025

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba