-
-
Notifications
You must be signed in to change notification settings - Fork 416
Different logic: verify equal before substr on ClassLikeNameClassNameImportSkipVoter #7450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...dingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php
Outdated
Show resolved
Hide resolved
|
I will add test to support short class name import on cover with existing class name. https://getrector.com/demo/8ed4f981-10db-4276-8c8a-edbcd3ff26c5 |
|
I added test fixture for short name use in class name 11e2c3a |
|
on no namespaced class name, short name conflict check is needed as make error on other tests, so I just skipped as current behaviour for now, updated the test. |
|
@TomasVotruba Let's merge so @JoshuaEstes and @simonschaufi can test :) |
|
@JoshuaEstes and @simonschaufi could you verify latest and verify is patch not cause regression? Thank you. |
|
👍 |
No description provided.