[dead-code] Add RemoveUnusedClosureVariableUseRector #7430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Oct 5, 2025
| continue; | ||
| } | ||
|
|
||
| $isUseUsed = (bool) $this->betterNodeFinder->findVariableOfName($node->stmts, $useVariableName); |
Member
There was a problem hiding this comment.
this should verify compact use as well, better use ExprUsedInNodeAnalyzer for it, I will create new PR for it.
Member
There was a problem hiding this comment.
I created new PR to skip used via compact()
samsonasik
reviewed
Oct 5, 2025
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\DeadCode\Rector\Concat; |
Member
There was a problem hiding this comment.
this should under Closure namespace:
-namespace Rector\DeadCode\Rector\Concat;
+namespace Rector\DeadCode\Rector\Closure;I will create new PR for it.
Member
There was a problem hiding this comment.
I create new PR to fix namespace to Closure
samsonasik
reviewed
Oct 5, 2025
Comment on lines
+86
to
+87
| // reset keys, to keep as expected | ||
| $node->uses = array_values($node->uses); |
Member
There was a problem hiding this comment.
this is not needed, already covered at NodeAttributeReIndexer, see
rector-src/src/Application/NodeAttributeReIndexer.php
Lines 69 to 71 in d948383
Member
There was a problem hiding this comment.
I created new PR for it:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by PHPStan, now fixed by Rector 👍
class Fixture { public function run($value) { - return function () use ($value) { + return function () { return 'value'; }; } }