feat: add greater and smaller support to StrlenZeroToIdenticalEmptyStringRector #7329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@calebdw thank you very much for taking care of this! I really appreciate! |
.../Rector/Identical/StrlenZeroToIdenticalEmptyStringRector/Fixture/might_not_be_string.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 25, 2025
.../Rector/Identical/StrlenZeroToIdenticalEmptyStringRector/Fixture/might_not_be_string.php.inc
Outdated
Show resolved
Hide resolved
601447a to
f913335
Compare
f913335 to
230c0f1
Compare
Member
|
Thank you @calebdw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This closes rectorphp/rector#9385
Thanks!
CC: @simonschaufi