fix: FunctionLikeToFirstClassCallableRector #7265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e72bd72 to
988488c
Compare
988488c to
6b8de93
Compare
Member
|
Looks good, thank you 💪🏻 |
samsonasik
reviewed
Sep 14, 2025
| Scope $scope | ||
| ): bool { | ||
| $params = $node->getParams(); | ||
| $args = $callLike->getArgs(); |
Member
There was a problem hiding this comment.
this ->getArgs() can't be moved too early calls, as it will cause assert error when already first class callable, see
, check firstClassCallable() first.
Contributor
Author
There was a problem hiding this comment.
I'll fix in a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I tried running this rule on my codebase, and there was a lot of breaks so this fixes those.
Additionally, I refactored the rule to remove duplication, improve readability, and make it more consistent with other rules (like adding a
shouldSkip()method).Thanks!