[type-declaration-docblocks] Add ClassMethodArrayDocblockParamFromLocalCallsRector #7259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99d8606 to
c542a09
Compare
…FromLocalCallsRector
c542a09 to
bbfd6bc
Compare
eb564cc to
e2727e0
Compare
samsonasik
reviewed
Sep 12, 2025
| use PhpParser\Node\Stmt\ClassMethod; | ||
| use Rector\Configuration\Parameter\FeatureFlags; | ||
|
|
||
| final class PrivateMethodFlagger |
Member
There was a problem hiding this comment.
this class should be on namespace Rector\TypeDeclaration namespace, since code logic is nothing todo with docblock,
using on docblock rules is fine, as a "user" that consume the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is array param docblock brother to already existing rule: https://getrector.com/rule-detail/add-method-call-based-strict-param-type-rector
Since param array type is not conflicting with any parent/child class (contrary to strict type declaration), we can add those even on public methods, that use local calls 👍
class SomeClass { public function go() { $this->run(['item1', 'item2']); } + /** + * @param string[] $items + */ private function run(array $items) { } }