fix: remove empty construct when parent has no construct #7239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Sep 11, 2025
samsonasik
reviewed
Sep 11, 2025
...ssMethod/RemoveEmptyClassMethodRector/Fixture/removed_empty_construct_when_no_parent.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Sep 11, 2025
Member
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, let's give it a try, thank you @calebdw
Member
|
I see for trait use why already checked, there is |
Member
|
Oh, it seems private empty __construct should be skipped as used on purpose to avoid instantiation |
Member
|
Ok, there is fixture for that already that checked on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Closes rectorphp/rector#9369
This fixes cases where an empty constructor isn't removed even when the parent does not have a constructor.
It turns out that the removed
ifstatement is not needed, the previous conditions already prevent overridden methods from being removed.Thanks!