fix: skip privatizing Laravel Model attributes and scopes #7218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Sep 4, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 4, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
Member
|
/cc @driftingly @GeniJaho could you help for review this, thank you. |
samsonasik
reviewed
Sep 4, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 4, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
c21e411 to
7229040
Compare
7229040 to
a563ce7
Compare
samsonasik
approved these changes
Sep 4, 2025
Member
samsonasik
left a comment
There was a problem hiding this comment.
I’m fine with this — let’s wait a bit to see if any of the Laravel folks have feedback :)
Contributor
|
Looks good to me as well 🙌 |
TomasVotruba
reviewed
Sep 4, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 5, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 5, 2025
rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Sep 5, 2025
Member
|
Looks good, thank you @calebdw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Please see #7144 (comment), this skips privatizing Laravel Model attributes and scopes as these are called in the parent Model class.
Thanks!