Skip to content

[depre] Deprecate AddParentSetupCallOnSetupRector as not generic to be automated, fill manually where needed #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

[depre] Deprecate AddParentSetupCallOnSetupRector as not generic to be automated, fill manually where needed #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions ...ity/Rector/Class_/AddParentSetupCallOnSetupRector/AddParentSetupCallOnSetupRectorTest.php
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ...s/CodeQuality/Rector/Class_/AddParentSetupCallOnSetupRector/Fixture/missing_setup.php.inc
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ...ctor/Class_/AddParentSetupCallOnSetupRector/Fixture/missing_setup_with_other_stmt.php.inc
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions ...deQuality/Rector/Class_/AddParentSetupCallOnSetupRector/Fixture/skip_setup_exists.php.inc
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions ...ests/CodeQuality/Rector/Class_/AddParentSetupCallOnSetupRector/config/configured_rule.php
View file
Open in desktop

This file was deleted.

56 changes: 4 additions & 52 deletions rules/CodeQuality/Rector/Class_/AddParentSetupCallOnSetupRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,17 @@
namespace Rector\PHPUnit\CodeQuality\Rector\Class_;

use PhpParser\Node;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Expression;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Rector\Exception\ShouldNotHappenException;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\MethodName;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddParentSetupCallOnSetupRector\AddParentSetupCallOnSetupRectorTest
* @deprecated as parent setup call depends on the test. Sometimes its on purpose, sometimes not. Better handle manually
*/
final class AddParentSetupCallOnSetupRector extends AbstractRector
{
public function __construct(
private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
private readonly BetterNodeFinder $betterNodeFinder,
) {
}

public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
Expand Down Expand Up @@ -76,43 +63,8 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if (! $this->testsNodeAnalyzer->isInTestClass($node)) {
return null;
}

$setUpMethod = $node->getMethod(MethodName::SET_UP);
if (! $setUpMethod instanceof ClassMethod) {
return null;
}

if ($setUpMethod->isAbstract() || $setUpMethod->stmts === null) {
return null;
}

$isSetupExists = (bool) $this->betterNodeFinder->findFirstInFunctionLikeScoped(
$setUpMethod,
function (Node $subNode): bool {
if (! $subNode instanceof StaticCall) {
return false;
}

if (! $this->isName($subNode->class, 'parent')) {
return false;
}

return $this->isName($subNode->name, 'setUp');
}
throw new ShouldNotHappenException(
sprintf('Rule "%s" is deprecated. Better add parent::setUp() manually where needed.', self::class)
);

if ($isSetupExists) {
return null;
}

$setUpMethod->stmts = [
new Expression(new StaticCall(new Name('parent'), new Identifier('setUp'))),
...$setUpMethod->stmts,
];

return $node;
}
}