Skip to content

Conversation

@TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-depre branch 2 times, most recently from c98f649 to 51edc78 Compare October 22, 2025 21:56
…pionated and requires very specific file location - use custom rule instead
@TomasVotruba TomasVotruba merged commit 11424b1 into main Oct 22, 2025
6 checks passed
@TomasVotruba TomasVotruba deleted the tv-depre branch October 22, 2025 22:00
@rectorphp rectorphp deleted a comment from samsonasik Oct 22, 2025
@maks-rafalko
Copy link
Contributor

maks-rafalko commented Oct 25, 2025

Add never used AddCoversClassAttributeRector

do you have some stats for rules? I don't know if others are using it, but we do use it in Infection and we (as a mutation testing library) highly promote the usage of #[CoversClass] that this rule helps to achieve.

So not sure why it was removed.

@TomasVotruba
Copy link
Member Author

Thanks for reaching out. We collect info from issue report, number of active sets, use on Github except forks etc.
https://github.com/search?q=AddCoversClassAttributeRector%3A%3Aclass&type=code
But there is more context.

I'm going through rules that are never used/mentioned in PR/issues/sets to narrow down core to more generic ones, that 80 %+ users would benefit from. These onezie rules are often experiments, or custom rules that we accepted in core to try out. This one is used just once, works with paths and all-class reflections.

That's why it's better fit as a custom rule, not in core. Move it to /utils in your project to keep using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants