Feature: support android 13+ language per-app #1934
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fire-light42
left a comment
There was a problem hiding this comment.
Good pull request.
We just need to figure out how to handle language regions such as English (New Zealand) which gets the language code en-NZ.
Comment on lines
227
to
231
| fun Context.updateLocale() { | ||
| val settingsManager = PreferenceManager.getDefaultSharedPreferences(this) | ||
| val localeCode = settingsManager.getString(getString(R.string.locale_key), null) | ||
| setLocale(this, localeCode) | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| fun Context.updateLocale() { | |
| val settingsManager = PreferenceManager.getDefaultSharedPreferences(this) | |
| val settingsLocale = settingsManager.getString(getString(R.string.locale_key), null) | |
| val localeCode = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) | |
| AppCompatDelegate.getApplicationLocales().get(0)?.toLanguageTag() ?: settingsLocale | |
| else | |
| settingsLocale | |
| setLocale(this, localeCode) | |
| } |
Collaborator
There was a problem hiding this comment.
I am thinking we use getApplicationLocales as the primary source of truth as to remove inconsistencies when setting it in android settings first and then app settings.
|
@fire-light42 sorry for the ping but will this be merged anytime soon? |
Contributor
Looks like there is still some work to do before this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs more testing. Feel free to continue the work if you want to.