Skip to content

fix(Fade): assign defaultProps to avoid undefined transition props in… #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Fade): assign defaultProps to avoid undefined transition props in… #4338

wants to merge 1 commit into from

Conversation

@VC-Semih
Copy link

@VC-Semih VC-Semih commented Jul 31, 2025

Changes to Fade.js

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR fixes an issue where the transition prop in PopperContent was undefined, causing PropType warnings and runtime errors when reading properties like timeout and baseClass in Fade. The problem was due to spreading Fade.defaultProps into PopperContent.defaultProps.transition.

Closes #2819

@VC-Semih
Copy link
Author

VC-Semih commented Jul 31, 2025 •
edited
Loading

Some context:
PopperContent.js -> defaultProps has transition: { ...Fade.defaultProps } that was undefined because Fade.js didn't have it's defaultProps correctly exported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning: Failed prop type: The prop transition.timeout is marked as required in PopperContent2, but its value is undefined.

1 participant

@VC-Semih