Skip to content

bugfix Badge colour is not working with bootstrap@5.3.x #4297 #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix Badge colour is not working with bootstrap@5.3.x #4297 #4337

wants to merge 1 commit into from

Conversation

@elaboratecon
Copy link

@elaboratecon elaboratecon commented Jul 26, 2025 •
edited
Loading

…lor standards on the badge component

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@elaboratecon
Copy link
Author

elaboratecon commented Jul 26, 2025

This addresses issue #4297

I reproed the issue using Codesandbox, first modifying package.json and associated code to reflect the library versions listed in the issue:
https://codesandbox.io/p/devbox/blazing-currying-lzk4ky?workspaceId=ws_FCSZKN4NMddcmrKh6txxF4

This updates the color class from the deprecated bg-color (ie "bg-warning") to match Bootstrap's 5.3.x standards (ie "text-bg-warning"):
https://getbootstrap.com/docs/5.3/components/badge/

Apologies for the crazy branch name.

@elaboratecon elaboratecon changed the title changed deprecated bg-color class to match bootstrap 5.3.x text-bg-co… bugfix Badge colour is not working with bootstrap@5.3.x #4297 Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nachogarciait nachogarciait nachogarciait approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elaboratecon @nachogarciait