-
-
Notifications
You must be signed in to change notification settings - Fork 316
Update refractor to version 5 #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update refractor to version 5 #604
Conversation
|
You'll need to get tests passing: This does bump our refractor dep by two major versions, so I'm not surprised that there are breaking changes. Failing CircleCI report: https://app.circleci.com/pipelines/github/react-syntax-highlighter/react-syntax-highlighter/428/workflows/79d934bd-1aae-45b9-befd-378c28334d1f |
|
Changes weren't that breaking surprisingly, just needed to change from node 16 to node 16.20.2 in the circleci image and add a jest config so refractor is transformed properly |
needed to upgrade node version for Object.hasOwn
0f42658 to
136289c
Compare
|
Just curious, should build folder be also included in that PR? |
|
Master branch has all the build contents inside it so I assumed it should be updated. |
|
@simmerer Any idea when or if this is going to be merged? |
|
This PR should also remove overrides section from package.json in case everything is OK, as it is no longer needed. |
|
@UncleJart I've removed the overrides |
|
@lodinukal And what is the reason chokidar was added to dev dependencies? |
|
It was added so that the demo |
|
@simmerer can you please clarify what conditions should be met for this PR to be merged? |
|
I am also waiting |
|
So sorry! I'll get this released tonight. |

This adds support for many languages in prism.js and resolves #603