Skip to content

Conversation

@lodinukal
Copy link
Contributor

This adds support for many languages in prism.js and resolves #603

@simmerer
Copy link
Collaborator

simmerer commented Aug 25, 2025

You'll need to get tests passing: npm run test

This does bump our refractor dep by two major versions, so I'm not surprised that there are breaking changes.

Failing CircleCI report: https://app.circleci.com/pipelines/github/react-syntax-highlighter/react-syntax-highlighter/428/workflows/79d934bd-1aae-45b9-befd-378c28334d1f

@simmerer simmerer added dependencies Pull requests that update a dependency file refractor labels Aug 25, 2025
@lodinukal
Copy link
Contributor Author

Changes weren't that breaking surprisingly, just needed to change from node 16 to node 16.20.2 in the circleci image and add a jest config so refractor is transformed properly

@lodinukal lodinukal force-pushed the update-refractor-v5 branch from 0f42658 to 136289c Compare August 26, 2025 13:14
@krudny
Copy link

krudny commented Aug 27, 2025

Just curious, should build folder be also included in that PR?

@lodinukal
Copy link
Contributor Author

Master branch has all the build contents inside it so I assumed it should be updated.

@lodinukal
Copy link
Contributor Author

@simmerer Any idea when or if this is going to be merged?

@mmgroner
Copy link

mmgroner commented Sep 3, 2025

This will also solve #606 and #607

@UncleJart
Copy link
Contributor

This PR should also remove overrides section from package.json in case everything is OK, as it is no longer needed.

@lodinukal
Copy link
Contributor Author

@UncleJart I've removed the overrides

@rteam-gthub
Copy link

@lodinukal And what is the reason chokidar was added to dev dependencies?

@lodinukal
Copy link
Contributor Author

It was added so that the demo npm run dev would work, otherwise it just complains that chokidar isn't installed
@rteam-gthub

@UncleJart
Copy link
Contributor

@simmerer can you please clarify what conditions should be met for this PR to be merged?

@xoxorwr
Copy link

xoxorwr commented Oct 16, 2025

image

@krudny
Copy link

krudny commented Oct 16, 2025

I am also waiting

@simmerer simmerer merged commit a0decc7 into react-syntax-highlighter:master Oct 22, 2025
1 check passed
@simmerer
Copy link
Collaborator

So sorry! I'll get this released tonight.

@simmerer
Copy link
Collaborator

simmerer commented Oct 22, 2025

It's out as 16.0.0!

https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases/tag/v16.0.0

https://www.npmjs.com/package/react-syntax-highlighter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file refractor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing Odin language support, despite being supported by prism

7 participants