Skip to content

Conversation

@Saadnajmi
Copy link

Overview

Most modern React Native repos have moved to Yarn 4. Let's do that here.

Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks about like what I'd expect from this move - you're ahead of me on verifying though, I was having trouble with the example since it's pretty out of date even though it is based on react-native-test-app which normally makes things pretty easy

need to work through both of these (the header import one and this one) before merging but I don't expect issues

@mikehardy mikehardy added the pending merge A PR that will be merged shortly, waiting for CI or final comment label Nov 13, 2024
@Saadnajmi
Copy link
Author

looks about like what I'd expect from this move - you're ahead of me on verifying though, I was having trouble with the example since it's pretty out of date even though it is based on react-native-test-app which normally makes things pretty easy

need to work through both of these (the header import one and this one) before merging but I don't expect issues

Hmm, I didn't test this with the example app since my experience has been yarn 4 upgrades generally work. I can try that real fast and maybe also update the example app while I'm at it. With the usual caveat I may be slow.

@mikehardy
Copy link
Contributor

You're faster than me at the moment! The react-native-test-app repo has a link to a PR they did that shows what it's like to upgrade from RNTA 2 to RNTA 3 (it's mostly erasing things), and the upgrade to react-native current is mostly just replacing the babel and metro entries with the new monorepo ones from the react-native repo. It should be relatively quick but it still takes me a couple hours each time because I test pretty methodically

@Saadnajmi
Copy link
Author

Saadnajmi commented Apr 14, 2025

@mikehardy Can this merge?

@Saadnajmi Saadnajmi closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending merge A PR that will be merged shortly, waiting for CI or final comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants