Skip to content

Fix missing thrust includes #167450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing thrust includes #167450

wants to merge 1 commit into from
+5 −1

Conversation

@miscco
Copy link

@miscco miscco commented Nov 10, 2025 •
edited by pytorch-bot bot
Loading

CCCL recently dropped a ton of transient includes that blew up thrust compile times

That means we need to include what we use

Fixes build issues found in internal CI

cc @ptrblck @msaroufim @eqy @jerryzh168

@miscco
Fix missing thrust includes
fc9c580 
CCCL recently dropped a ton of transient includes that blew up thrust compile times

That means we need to include what we use
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167450

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 15 Pending

As of commit fc9c580 with merge base 3cfbf98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Nov 10, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 10, 2025

CLA Not Signed

@Aidyn-A Aidyn-A added module: cuda Related to torch.cuda, and CUDA support in general enhancement Not as big of a feature, but technically not a bug. Should be easy to fix topic: not user facing topic category and removed release notes: sparse release notes category labels Nov 10, 2025
@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 10, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 10, 2025
@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 10, 2025

Oh whoops, you need to sign CLA first

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 10, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Aidyn-A
Copy link
Collaborator

Aidyn-A commented Nov 10, 2025

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A Aidyn-A is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miscco @Skylion007 @pytorchmergebot @Aidyn-A @pytorchbot