Skip to content

Fixed false logging warning #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstasiak merged 1 commit into from
Jun 2, 2020
Merged

Fixed false logging warning #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion zeroconf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,9 @@ def packets(self) -> List[bytes]:
authority_offset += authorities_written
additional_offset += additionals_written
log.debug("now offsets = %d, %d, %d", answer_offset, authority_offset, additional_offset)
if answers_written == 0 and authorities_written == 0 and additional_offset == 0:
if (answers_written + authorities_written + additionals_written) == 0 and (
len(self.answers) + len(self.authorities) + len(self.additionals)
) > 0:
log.warning("packets() made no progress adding records; returning")
break
self.state = self.State.finished
Expand Down