fix: create listener socket with specific IP version #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1557 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1557 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 33 33
Lines 3392 3393 +1
Branches 463 463
=======================================
+ Hits 3385 3386 +1
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
can you add a test (only if IPv6 is available.. there is a fixture already) that creates and IPv4 and IPv6 one with unicast? |
Create listener sockets when using unicast with specific IP version as well, just like in `new_respond_socket()`.
c236aee to
f16a922
Compare
bdraco
approved these changes
Apr 1, 2025
Member
|
Thanks @agners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create listener sockets when using unicast with specific IP version as well, just like in
new_respond_socket().