Skip to content

Conversation

@Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Feb 16, 2025

Must use single quotes and prevent always true.

Reference

fix pervious attempt #1441
fixes #1440

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (1c7f354) to head (a2f144c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1530   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          33       33           
  Lines        3388     3388           
  Branches      462      462           
=======================================
  Hits         3381     3381           
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #1530 will not alter performance

Comparing Rotzbua:fix_release (a2f144c) with master (1c7f354)

Summary

✅ 6 untouched benchmarks

@bdraco bdraco changed the title fix(ci): run release workflow only on main repository chore(ci): run release workflow only on main repository Feb 16, 2025
@Rotzbua Rotzbua marked this pull request as draft February 16, 2025 00:58
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 16, 2025

seems i still miss something... there should be no release attempt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: release process runs on forks

2 participants