Add P105(US) device fixture #1644
Open
+358
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for the P105(US) smart plug device by including a device fixture file and updating documentation to list P105 as a supported device.
Changes:
- Added device fixture file for P105(US) hardware version 1.0, firmware 1.2.5
- Updated README.md to include P105 in the list of supported Tapo plug devices
- Updated SUPPORTED.md to document the tested P105 hardware and firmware version
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/fixtures/smart/P105(US)_1.0_1.2.5.json | New device fixture containing component negotiation, discovery result, device info, and configuration data for P105(US) smart plug |
| README.md | Added P105 to the supported plugs list in alphabetical order |
| SUPPORTED.md | Added P105 hardware 1.0 (US) / Firmware 1.2.5 entry under Plugs section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 157 157
Lines 9649 9649
Branches 976 976
=======================================
Hits 8957 8957
Misses 492 492
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add P105(US) device fixture