Skip to content

Improve import times #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eriknw merged 1 commit into from
Mar 29, 2023
Merged

Improve import times #419

eriknw merged 1 commit into from
Mar 29, 2023

Conversation

@eriknw
Copy link
Member

@eriknw eriknw commented Mar 28, 2023

Import times regressed in #388. This PR fixes it.

A nice way to visualize import times is with https://github.com/nschloe/tuna

Now, as before, import times are dominated by numba and numpy.

I looked at timing for "Test Imports" Github Actions to identify what caused the regression:
https://github.com/python-graphblas/python-graphblas/actions/workflows/imports.yml

@eriknw eriknw added regression performance performance related issue labels Mar 28, 2023
@eriknw
Copy link
Member Author

eriknw commented Mar 28, 2023

For example, to use tuna:

python -X importtime -c "from graphblas import *" 2> import.log
tuna import.log

@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 99.445% (-0.05%) from 99.491% when pulling bcd9d22 on eriknw:fix_import_time into 41fb71a on python-graphblas:main.

@eriknw eriknw merged commit 0139a83 into python-graphblas:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes

Assignees

No one assigned

Labels

performance performance related issue regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eriknw @coveralls @jim22k