Skip to content

Fix infix expression _value and _expr usage #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eriknw merged 1 commit into from
Mar 28, 2023
Merged

Fix infix expression _value and _expr usage #418

eriknw merged 1 commit into from
Mar 28, 2023

Conversation

@eriknw
Copy link
Member

@eriknw eriknw commented Mar 28, 2023

Previously, infixexpr._value was sometimes MatrixExpression and sometimes Matrix. Scary!

Fixes #416.

@eriknw
Fix infix expression _value and _expr usage
ff1fcb5 
Previously, `infixexpr._value` was sometimes `MatrixExpression` and sometimes `Matrix`. Scary!
@eriknw eriknw requested a review from jim22k March 28, 2023 16:00
@eriknw eriknw added the bug Something is broken label Mar 28, 2023
@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 99.43% (-0.07%) from 99.499% when pulling ff1fcb5 on eriknw:fix416 into 0c1b102 on python-graphblas:main.

@eriknw eriknw merged commit 41fb71a into python-graphblas:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes

Assignees

No one assigned

Labels

bug Something is broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_repr_html_ broken for m @ m.T

3 participants

@eriknw @coveralls @jim22k