Skip to content

Conversation

@SultanOrazbayev
Copy link
Member

@SultanOrazbayev SultanOrazbayev commented Mar 10, 2023

Adds Python version badges and description of optional dependencies in README.md.

Partially addresses #402

Adds Python version badges
@coveralls
Copy link

coveralls commented Mar 10, 2023

Coverage Status

Coverage: 99.494% (+0.07%) from 99.425% when pulling 7d9452b on SultanOrazbayev:patch-6 into 673650d on python-graphblas:main.

optional dependencies copied from docs
@eriknw
Copy link
Member

eriknw commented Mar 10, 2023

LGTM, thanks @SultanOrazbayev.

We can close #402 if you add yourself to Maintainers (if you'd like, and up to you if you want to include your email). I like the discussion around "who is a maintainer" from a recent NetworkX meeting where the prevailing opinion was that "maintainer" means being an active maintainer, which means actively engaging in discussions, PRs, and/or creating PRs. You definitely qualify :) . Plus, you're already a member in the github org.

I think we should also include "Python-graphblas Contributors" in the authors section of pyproject.toml.

@SultanOrazbayev
Copy link
Member Author

SultanOrazbayev commented Mar 11, 2023

Thank you, Erik!

re: contributor section
I couldn't find the name for @ParticularMiner , and then thought maybe it's OK to include just GitHub handles. That didn't work out. :/

Removed `contributors` (not a valid key for project description it seems):
```
contributors = [
    {GitHub_handle = "eriknw"},
    {GitHub_handle = "jim22k"},
    {GitHub_handle = "ParticularMiner"},
    {GitHub_handle = "SultanOrazbayev"},
    {GitHub_handle = "seibert"},
]
```
@eriknw eriknw merged commit a0c152c into python-graphblas:main Mar 11, 2023
@eriknw
Copy link
Member

eriknw commented Mar 11, 2023

This is in, thanks @SultanOrazbayev (and welcome as a more-officially recognized maintainer)!

And, yeah, no need to include all the names or github handles of all the contributors under authors. The git log and github has a record of that, and the authorship shows up properly in Zenodo.

It's sad that ParticularMiner seems to have disappeared 8 months ago. I hope he's okay and simply too busy having fun ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants