Skip to content

bpo-37324: Remove ABC aliases from collections #14171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 1 commit into from
Closed

bpo-37324: Remove ABC aliases from collections #14171

vstinner wants to merge 1 commit into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 17, 2019 •
edited by bedevere-bot
Loading

Remove deprecated aliases to Abstract Base Classes from the
collections module.

https://bugs.python.org/issue37324

@vstinner
bpo-37324: Remove ABC aliases from collections
0141eeb 
Remove deprecated aliases to Abstract Base Classes from the
collections module.
@vstinner vstinner requested a review from rhettinger as a code owner June 17, 2019 20:44
@vstinner
Copy link
Member Author

vstinner commented Jun 17, 2019

pip is broken by this change, causing test_venv to fail: https://bugs.python.org/issue37324#msg345906

@tirkarthi
Copy link
Member

tirkarthi commented Jun 17, 2019

Vendored html5lib in pip was fixed upstream but needs a new release to fix thjs. See also discussion at #10596

@vstinner
Copy link
Member Author

vstinner commented Jun 17, 2019

Oh. I wasn't aware of the previous attempt: #10596 there is a long discussion there.

Vendored html5lib in pip was fixed upstream but needs a new release to fix thjs. See also discussion at #10596

I also found some info about that: https://bugs.python.org/issue37324#msg345908

@vstinner vstinner mentioned this pull request Jun 17, 2019
Merged
@vstinner
Copy link
Member Author

vstinner commented Jun 20, 2019

It seems like jinja2 should be updated:

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/utils.py:485: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import MutableMapping

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/runtime.py:318: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import Mapping

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/sandbox.py:82: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import MutableSet, MutableMapping, MutableSequence

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 21, 2019
@vstinner
Copy link
Member Author

vstinner commented Jul 16, 2019

This PR cannot be merged because it breaks the Python CI because of html5lib (used by pip): https://bugs.python.org/issue37324#msg348011 I prefer to close this PR right now. I will not be available next weeks, so I prefer to close the PR. I may reopen it later, once html5lib and pip are fixed.

@vstinner vstinner closed this Jul 16, 2019
@hugovk hugovk mentioned this pull request Dec 13, 2020
Merged
@vstinner vstinner deleted the collections_remove_abc branch January 19, 2021 21:59
@vstinner vstinner mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @tirkarthi @brettcannon @the-knights-who-say-ni @bedevere-bot