Skip to content

Conversation

@WebReflection
Copy link
Contributor

Description

This MR fixes #2360 by handling properly all x-editors that are sharing the same env or depends on the same setup node.

Changes

  • improve handling of setup and shared envs to bootstrap from scratch all related editors
  • manually test that everything works as expected (as it's hard to do an integration test here)

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll July 10, 2025 10:57
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection force-pushed the stack branch 2 times, most recently from 9cfe01b to dd369d4 Compare July 10, 2025 13:26
@WebReflection WebReflection merged commit eaa6711 into pyscript:main Jul 11, 2025
2 checks passed
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Jul 21, 2025
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Jul 21, 2025
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Aug 6, 2025
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Aug 6, 2025
WebReflection added a commit that referenced this pull request Aug 6, 2025
* Fix #2360 - Better shared env/setup handling (#2361)

* Updated Polyscript to its latest

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* changed is_null to a more Pythonic is_none

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Aug 6, 2025
* Fix pyscript#2360 - Better shared env/setup handling (pyscript#2361)

* Updated Polyscript to its latest

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* changed is_null to a more Pythonic is_none

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyEditor stop is actually not stopping when setup and shared env are used

2 participants