Refactor test generation to reduce diff noise when adding new options #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While exploring how to implement my own extension, I noticed that adding a new argument to
tests::test_markdown_htmlcauses 1000+ lines of changes, because every test cases requires an additionalfalseargument. For example, in PR #991, more than half of the diff is just adding an extrafalsetotest_markdown_html.So I think it is a good idea to refactor the test generation to reduce the diff noise.
Solution
Introduce a configuration struct (with
#[derive(Default)]) to hold all test options. This allows new options to be added without modifying every single test invocation, only the tests that actually depend on the new option need to be updated.