fix(aws/cfn): irrecoverable stack status (spinnaker#3695) (spinnaker#…

…3700)

* fix(aws/cfn): irrecoverable stack status

In a Deploy Cloudformation stage, when a stack creation fails, it goes to an irrecoverable status ROLLBACK_COMPLETE.  AWS rollbacks the changes made. Even if the changes are made to the template to solve the issue why the stack creation failed, the stack needs to be deleted in order to re-run the stage successfully.
Before this changes, when a CFN stage tried to create a stack (without a changeset) and creation failed, error message explained the reason why the creation failed; but it didn't explain that the stack needs to be deleted to re-run the stage.
When the same scenario happened and a change set creation was requested, the error message was  "NOT_YET_READY", which it does not reflect what actually happened.
With this changes, error message will explain steps to take and reason why the creation failed.

* Adding unrecoverable statuses.

Co-authored-by: Ariadna Rouco <ariadna.rouco@adevinta.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit edc9a99)

Co-authored-by: Aria <ariadna.rouco@gmail.com>

Revert "fix(imagetagging): asset foundImage count >= upstreamImageIds…

… count (spinnaker#2799)" (spinnaker#2807)

This reverts commit 0d25d50.

fix(imagetagging): asset foundImage count >= upstreamImageIds count (s…

…pinnaker#2799)

chore(logging): remove high volume logs used to debug old issue

chore(clouddriver): rest helper for deploying clouddriver-sql with an…

… empty cache (spinnaker#2690)

fix(loadbalancer): wait for onDemand cache processing when supported (s…

…pinnaker#2795)

feat(clouddriver): Remove ec2-classic migration code (spinnaker#2794)

fix(queue): Ensure that after stages run with an authenticated context (

spinnaker#2791)

This addresses a situation where the `DeployCanaryStage` failed to
plan after stages that involved a lookup against a restricted account.

fix(conditions): Make task conditional per config (spinnaker#2790)

- s/@ConditionalOnBean/@ConditionalOnExpression

fix(clouddriver): Reduce jardiff connect/read timeouts (spinnaker#2786)

This handles situations where a security group may prevent ingress
and otherwise timeout after the default (10s).

We automatically retry 5 times so our deployments are taking _at least_
50s longer than they need to.

This isn't perfect but that 50s will be lowered to 10s.