-
Notifications
You must be signed in to change notification settings - Fork 8k
Icu tocxx 6 #20443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devnexen
wants to merge
7
commits into
php:master
Choose a base branch
from
devnexen:icu_tocxx_6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Icu tocxx 6 #20443
+713
−1,080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
Girgias
reviewed
Nov 11, 2025
| #include "zend_string.h" | ||
| #include "zend_sort.h" | ||
|
|
||
| BEGIN_EXTERN_C() |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the enum exists in 8.5 this probably should be backported too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ABI break
Category: Build System
Category: Engine
Extension: curl
Extension: date
Extension: enchant
Extension: fileinfo
Extension: ftp
Extension: gd
Extension: hash
Extension: intl
Extension: ldap
Extension: libxml
Extension: mysqli
Extension: odbc
Extension: openssl
Extension: pdo (core)
Extension: pgsql
Extension: random
Extension: reflection
Extension: shmop
Extension: sodium
Extension: spl
Extension: standard
Extension: uri
Extension: xml
Extension: zend_test
Extension: zip
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.