Merged
Conversation
This is a better measure and also runs faster.
221c4c3 to
ee208b1
Compare
ee208b1 to
e14db88
Compare
e14db88 to
0a4af17
Compare
0a4af17 to
cfdc3c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Eulerian path algorithm, when trying to find which bidirectional paths to assign a direction to, has to compute the scores of all possibilities. This is very slow. Rather than do that, we can keep a cache of the scores that we know about so far. We can also keep a sorted tree of those scores so that finding the path with the best score is quick.
This fixes #769