ci: Include integration tests as part of coverage.#752
Merged
eyal0 merged 6 commits intopcb2gcode:masterfrom Jan 15, 2026
Merged
ci: Include integration tests as part of coverage.#752eyal0 merged 6 commits intopcb2gcode:masterfrom
eyal0 merged 6 commits intopcb2gcode:masterfrom
Conversation
The code coverage includes the integration tests and we want to run them on a consistent version of geos. Otherwise, they might not pass.
01fc621 to
23c202e
Compare
We still can't run on Windows because it gets the wrong answers. The integration tests are now run on all Ubuntu platforms with geos 3.13.1, which means that it runs for both g++ and g++-10. The code coverage should be combined.
23c202e to
ddbb6bc
Compare
Just in case the valgrind confuses the code coverage collection.
405daaf to
229e392
Compare
Collaborator
It's slower on the newer g++ for some reason.
3e47ef1 to
97cf605
Compare
timaydin
pushed a commit
to timaydin/pcb2gcode
that referenced
this pull request
Jan 27, 2026
ci: Include integration tests as part of coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration testing is a big part of coverage. We accidentally removed this in #730.