refactor: Move the path data into the path_manager.#736
Closed
eyal0 wants to merge 8 commits intopcb2gcode:masterfrom
Closed
refactor: Move the path data into the path_manager.#736eyal0 wants to merge 8 commits intopcb2gcode:masterfrom
eyal0 wants to merge 8 commits intopcb2gcode:masterfrom
Conversation
Collaborator
…one. Let the caller do a loop.
Contributor
Author
|
Progress on #733. I can confirm that eulerian_paths are the problem. Disabling the feature is no good because it makes the code way too slow. I have fixed up the problem a little bit already. Here's what the output looks like on
Here's what it looks like on tag
Better. And here's what it looks like if I disable eulerian paths on line 519 of surface_vectorial.cpp:
It ran a little slower but it is perfect. It will also mill slower due to not joining paths. I will write try to whittle down that run of the eulerian algorithm to figure out what's going wrong. |
Contributor
Author
|
Oh no the test case is 11000+ linestrings. It's so big that I can't compile it. I have to read it from a file dynamically for now. :-( |
Contributor
Author
|
Done in #740 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.