Skip to content

refactor: Move the path data into the path_manager.#736

Closed
eyal0 wants to merge 8 commits intopcb2gcode:masterfrom
eyal0:path_manager2
Closed

refactor: Move the path data into the path_manager.#736
eyal0 wants to merge 8 commits intopcb2gcode:masterfrom
eyal0:path_manager2

Conversation

@eyal0
Copy link
Copy Markdown
Contributor

@eyal0 eyal0 commented Dec 16, 2025

No description provided.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 16, 2025

Coverage Status

coverage: 58.939% (-0.07%) from 59.007%
when pulling e30ea42 on eyal0:path_manager2
into 6c8e590 on pcb2gcode:master.

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented Dec 16, 2025

Progress on #733.

I can confirm that eulerian_paths are the problem. Disabling the feature is no good because it makes the code way too slow. I have fixed up the problem a little bit already.

Here's what the output looks like on master branch for one example.

image

Here's what it looks like on tag 928a7809:

image

Better. And here's what it looks like if I disable eulerian paths on line 519 of surface_vectorial.cpp:

image

It ran a little slower but it is perfect. It will also mill slower due to not joining paths.

I will write try to whittle down that run of the eulerian algorithm to figure out what's going wrong.

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented Dec 17, 2025

Oh no the test case is 11000+ linestrings. It's so big that I can't compile it. I have to read it from a file dynamically for now. :-(

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented Dec 18, 2025

Done in #740

@eyal0 eyal0 closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants