Skip to content

ci: Fix release artifacts#731

Merged
eyal0 merged 2 commits intopcb2gcode:masterfrom
mar0x:ci-fix-release-artifacts
Dec 8, 2025
Merged

ci: Fix release artifacts#731
eyal0 merged 2 commits intopcb2gcode:masterfrom
mar0x:ci-fix-release-artifacts

Conversation

@mar0x
Copy link
Copy Markdown
Contributor

@mar0x mar0x commented Nov 27, 2025

Build matrix was changed in PR #730 . Release scripts were tightly coupled with the matrix.

This PR changes artifact archive naming to include version and git hash and reduces release scripts.

Release was accidentally broken in f6e0579 by build matrix change.

Artifact name now includes version and hash to simplify release
process.
Directory .libs in windows binary archive is useless.
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 59.007%. remained the same
when pulling 56f7416 on mar0x:ci-fix-release-artifacts
into e251364 on pcb2gcode:master.

@mar0x
Copy link
Copy Markdown
Contributor Author

mar0x commented Dec 5, 2025

Hello,
Is there something I can improve to merge this?

@eyal0
Copy link
Copy Markdown
Contributor

eyal0 commented Dec 5, 2025

I missed the email! I will look at this soon. Thanks!

@eyal0 eyal0 merged commit badf6ae into pcb2gcode:master Dec 8, 2025
13 checks passed
@eyal0
Copy link
Copy Markdown
Contributor

eyal0 commented Dec 8, 2025

Thanks for your continued help!

@eyal0
Copy link
Copy Markdown
Contributor

eyal0 commented Dec 8, 2025

Oy, not it isn't passing CI. Any ideas? Looks like boost is missing in the windows build...

@mar0x
Copy link
Copy Markdown
Contributor Author

mar0x commented Dec 8, 2025

Oy, not it isn't passing CI. Any ideas? Looks like boost is missing in the windows build...

Something changed or goes wrong. I'll look at this tomorrow...

@mar0x
Copy link
Copy Markdown
Contributor Author

mar0x commented Dec 15, 2025

Please have a look at #734 - an attempt to fix missing boost and another try to fix CI (for Windows).

timaydin pushed a commit to timaydin/pcb2gcode that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants