feat: Make circles less "chunky" by using more segments in their polygonal approximation.#716
Merged
eyal0 merged 15 commits intopcb2gcode:masterfrom Jun 6, 2025
Merged
Conversation
5543dcc to
7832afb
Compare
51cc34d to
6415d1c
Compare
This is a step on the way to make all curves this way.
This is a step on the way to make all curves this way.
This is a step on the way to make all curves this way.
timaydin
pushed a commit
to timaydin/pcb2gcode
that referenced
this pull request
Jan 27, 2026
feat: Make circles less "chunky" by using more segments in their polygonal approximation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than always use 32 segments per circle, use as many as necessary to achieve 0.0004 inch or less per segment. (0.0004 inches is the default tolerance value.)
This fixes #661