Update Windows build instructions in README#658
Merged
eyal0 merged 1 commit intopcb2gcode:masterfrom Feb 11, 2023
Merged
Conversation
This PR updates the `README.md` file with instructions that actually work on my machine, as listed in pcb2gcode#655 The following changes are made: - Change "Windows prebuilt binaries **are** available" to "... **may be** available". Also I've added a little explanation as to why the Windows builds may be missing. It's intentionally vague so that it doesn't need updating for every release. - Use the currently used names for the 32-bit and 64-bit MSYS2 shells. - Write the instructions for 64-bit builds, leaving it up to the reader to adjust for 32-bit builds (instead of vice versa). - Change the Gerbv instructions to use the current fork on Github, which actually builds on a current install of MSYS2. - Remove the `--prefix=/mingw<NN>` options from the `configure` invocations, as they don't seem to be necessary. And it'll make for less adjustments when doing a 32-bit build. - Add a command to autmatically find and copy the required DLLs.
Contributor
|
Looks great! Would you like to fix the CI now? 🤣 As I recall, the problem with the Windows build is that the compiler kept running our of memory! I think that the problem was the CI servers and infrastructure and not the CI that I wrote. Total pain in the ass. I'm glad that it's working for you! |
Collaborator
Contributor
Author
I might just do that some day. Not today though ;-)
That's good to know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
README.mdfile with instructions that actually work on my machine, as listed in #655The following changes are made:
--prefix=/mingw<NN>options from theconfigureinvocations, as they don't seem to be necessary. And it'll make for less adjustments when doing a 32-bit build.This fixes #655