Open
Conversation
eaf0ad1 to
926a147
Compare
Collaborator
3624068 to
1120db8
Compare
We don't need to store it as a layer internally because we only ever use it as a shape.
Previously we used the first surface's dimensions but that wasn't a very clean solution.
This allows the milling to include the area under the tool, which can remove burrs.
When tiling, the isolator will try to overlap the cutter in order to remove burrs. Account for the overlap.
1120db8 to
fc33e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #652